scene, server: improve DMABUF import #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure of the performance implications of calling eglQueryDmaBufFormatsEXT and eglQueryDmaBufModifiersEXT (I was too lazy to benchmark either) but it's nice to have them queried ahead of time to be able to print them out for debugging purposes regardless. At some point I should probably just cave and link libdrm. It will probably finally need to happen whenever I get around to supporting explicit sync in the DMABUF importing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a minimum this PR should fix the GL_INVALID_OPERATION errors people have been experiencing on some Nvidia systems, but I'd like to improve the logging to make debugging this easier in the future (if more issues occur) and would also like to improve the DRM format/modifier validation stuff.