Skip to content

PHP 8.1-8.3 code hardening + PHP 8.4 version bump #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

hopeseekr
Copy link
Contributor

@hopeseekr hopeseekr commented Dec 23, 2024

All copyright and IP rights transferred from PHP Experts, Inc., to @brendt [email protected].

This is a corporate code donation.

Fixes #165.

Verified

This commit was signed with the committer’s verified signature.
hopeseekr Theodore R. Smith

Verified

This commit was signed with the committer’s verified signature.
hopeseekr Theodore R. Smith

Verified

This commit was signed with the committer’s verified signature.
hopeseekr Theodore R. Smith

Verified

This commit was signed with the committer’s verified signature.
hopeseekr Theodore R. Smith
Fixes Issue tempestphp#165.
@brendt
Copy link
Member

brendt commented Jan 9, 2025

I don't think this is the way to go: added readonly to classes is a breaking change. Furthermore, I personally don't want to use #[Override]: https://stitcher.io/blog/override-in-php-83

@brendt brendt closed this Jan 9, 2025
@hopeseekr
Copy link
Contributor Author

Is there an API server for this actual project?

https://highlight.phpexperts.pro/ provides a simple API server for this project currently, but because this PR and others from me have been rejected, it seems that in the near future, it will start serving content from the forked version instead...

This API service is accessible to any language, evne plain HTML + a single JS and CSS include. It's the only way I could get it on my non-PHP 8.3 websites (almost all of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update minimal PHP requirement to 8.4
2 participants