Skip to content

Allow included and excluded files in CSV exporter if there is no overlap #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

facuerrobidart
Copy link
Contributor

@facuerrobidart facuerrobidart commented May 5, 2025

The CSVExporter has been updated to support the simultaneous setting of included_files and excluded_files. The implementation now includes a check for any overlap between these two lists, raising an error if and only if common elements are found.

Fixes: #1560

@facuerrobidart facuerrobidart marked this pull request as ready for review May 5, 2025 00:20
@facuerrobidart facuerrobidart marked this pull request as draft May 5, 2025 00:22
@facuerrobidart facuerrobidart marked this pull request as ready for review May 5, 2025 00:28
@dehall dehall merged commit c807432 into synthetichealth:master May 7, 2025
2 checks passed
@dehall
Copy link
Contributor

dehall commented May 7, 2025

Thank you for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected results from CSV Exporter included/excluded files settings
2 participants