-
Notifications
You must be signed in to change notification settings - Fork 742
feat(provider_finder): Add 'prefer_one' provider finding strategy #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrequina
wants to merge
6
commits into
synthetichealth:master
Choose a base branch
from
andrequina:add_prefer_one_provider_feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(provider_finder): Add 'prefer_one' provider finding strategy #1567
andrequina
wants to merge
6
commits into
synthetichealth:master
from
andrequina:add_prefer_one_provider_feature
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new provider finding strategy, `ProviderFinderPreferOne`, which allows configuring Synthea to prioritize a specific provider based on their NPI. Key changes include: - Added `ProviderFinderPreferOne.java` implementing the new logic. - Integrated `ProviderFinderPreferOne` into `Generator.java` to: - Set the initial simulation state based on the preferred provider's location. - Allow overriding patient demographics based on the preferred provider. - Added the `prefer_one` option to the provider finding mechanism in `Provider.java`. - Refactored provider file path handling in `Provider.java` for clarity and to support locating the preferred provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/main/resources/synthea.properties: Language not supported
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Outdated
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Outdated
Show resolved
Hide resolved
jawalonoski
requested changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about the expected behavior of this finder.
...ava/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOneTest.java
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Outdated
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Outdated
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Outdated
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Show resolved
Hide resolved
...in/java/org/mitre/synthea/world/agents/behaviors/providerfinder/ProviderFinderPreferOne.java
Show resolved
Hide resolved
1. Implement caching in the getPreferredProvider method to avoid repeated lookups of the same provider. This optimization improves performance by storing the provider once found and returning the cached instance on subsequent calls with the same NPI. 2. Throw ExceptionInInitializerError in overrideDemographicsIfPreferredProvider when the provider is not found by NPI.
…der is not set. Update getPreferredNPI to check if preferred provider selection behavior is enabled before retrieving the NPI from configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new provider finding strategy,
ProviderFinderPreferOne
, which allows configuring Synthea to prioritize a specific provider based on their NPI.Key changes include:
ProviderFinderPreferOne.java
implementing the new logic.ProviderFinderPreferOne
intoGenerator.java
to:prefer_one
option to the provider finding mechanism inProvider.java
.Provider.java
for clarity and to support locating the preferred provider.