Number app #18
Open
Number app #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenrog
reviewed
Aug 29, 2020
| //Set color and then reset it after the error | ||
| Console.ForegroundColor = ConsoleColor.Red; | ||
| Console.Write(" ERROR: FORMAT EXCEPTION"); | ||
| Console.ResetColor(); |
| Console.WriteLine(); | ||
| } | ||
|
|
||
| Console.WriteLine("Total: " + inputTotal + " Average: " + Math.Round(inputTotal / (double)inputLength, 3)); |
There was a problem hiding this comment.
Hmm, missade att man skulle ha det också. Ska jag uppdatera med det eller ska jag låta det vara för den här gången?
Jag hade troligen gjort nånting i stil med
if(maxValue < numberParse) { maxValue = numberParse; }
i TryParse if-satsen på rad 25 (och med ett minValue).
Ser att jag hade nån onödig convert to double där också.
There was a problem hiding this comment.
Ja, du fattar principen, behövs ej. Jag hade skrivit numberParse > maxValue (samma sak, men min hjärna läser det lättare).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise in numbers. It currently doesn't edit out faulty entries, but instead ignores them.