Skip to content

fix: hydration for null body http status response #13985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shoaibakhtar9611
Copy link

Fix for issue: 13972

Root cause:

The hydration logic in [initial_fetch](https://github.com/sveltejs/kit/blob/main/packages/kit/src/runtime/client/fetcher.js#L88C17-L88C30) constructing a Response using empty string as the response body, which is invalid for null body status codes (101, 103, 204, 205, 304) as per Fetch specs. This lead to the error:

TypeError: Failed to construct 'Response': Response with null body status cannot have body

This PR basically updates the [text()](https://github.com/sveltejs/kit/blob/main/packages/kit/src/runtime/server/page/load_data.js#L325) function:

When the response status is null body status, and the .text() result is empty string, we now:

  • Skip pushing the body to fetched array
  • Return undefined instead of an empty string
  • Avoid capturing a body for a response that must not have one

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: 192aea8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant