Migrate to official mongo-driver + go modules #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 24
💛 - Coveralls |
|
This is great, thank you! I will review within the next week |
|
hey @michaelfinch would love to get this contributed back whenever you have some time to review - thanks 👍 |
daniel-nichter
approved these changes
Dec 8, 2020
|
Sorry for the delay. Looks good, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry in advance for the rather lengthy pull request.
I had a need to use this locking library with a MongoDB Atlas cluster and the mgo library didn't support
mongodb+srvlookups so I decided to rewrite it. In the process I also migrated the library to a go module (let me know if you want to split this up).The biggest API difference (breaking change) is every method now takes a context as its first argument.
Thanks for the review + library.
Closes #3