Add RBS option #140
Open
Add RBS option #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]>
|
I mentioned this in a previous PR: I’m reluctant to advertise this with a button. To be able to include it in the dropdown, I would at least want sorbet.run to be able to forward those flags to the LSP client too. Right now the query string parameters only work in the command output pane, but do not do anything in the LSP side. if you want to add support for putting those flags into the web assembly startup so that the RBS comments will affect IDE output too, then I would be willing to consider putting this option here. Otherwise people will just be confused why the IDE doesn’t work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a menu to make it easier to use RBS in the playground: