fix: update extended component for DefsView #2674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
requested changes
May 7, 2025
| import android.view.View; | ||
| import com.facebook.react.bridge.ReactContext; | ||
|
|
||
| @SuppressLint("ViewConstructor") | ||
| class DefsView extends DefinitionView { | ||
| class DefsView extends RenderableView { |
There was a problem hiding this comment.
DefinitionView is the exact fit for Defs; instead of changing it to Renderable, we should move the necessary functions from Renderable to Definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That problem occurred only on the Android platform because we missed the correct implementation for the Defs component.
Summary
Defsshould extend fromRenderableViewand should have base methods. Previously,DefsViewwas extended byDefinitionViewFixed issues:
#2615
#2616
Test Plan
You can easily run an example application with Test2615 and Test2616, which I've created.
What's required for testing (prerequisites)?
The app shouldn't crash.
Compatibility