Skip to content

feat: confirmation modal for D and p #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

kennyfrc
Copy link
Contributor

@kennyfrc kennyfrc commented Jun 4, 2025

This change introduces a confirmation dialog when deleting an instance and when pushing changes to GitHub.

Fixes #102.

Also adds a test file called app/app_test.go that you can run with go test ./app -run TestConfirm -v.

@mufeez-amjad
Copy link
Member

mufeez-amjad commented Jun 4, 2025

@kennyfrc thanks so much for your PR, this is great!

I pushed c634fc2 which adds a new confirmationOverlay instead of re-using the textOverlay, as well as cleaning up the dialog slightly.

CleanShot.2025-06-04.at.00.06.37.mp4

@mufeez-amjad mufeez-amjad force-pushed the kennyfrc/confirmation-modal branch from d51e3e1 to c634fc2 Compare June 4, 2025 04:12
@mufeez-amjad mufeez-amjad force-pushed the kennyfrc/confirmation-modal branch from c634fc2 to eb46057 Compare June 4, 2025 04:19
@mufeez-amjad mufeez-amjad merged commit dca886d into smtg-ai:main Jun 4, 2025
6 checks passed
@kennyfrc
Copy link
Contributor Author

kennyfrc commented Jun 4, 2025

@mufeez-amjad Great, thank you! Thanks as well for the project - I've been using it daily.

@jayshrivastava
Copy link
Collaborator

👋🏽 @kennyfrc Would you mind signing our CLA? If you could comment that you have read and agree to the terms, that would be great. Thanks again for the contribution!

@kennyfrc
Copy link
Contributor Author

I have read and I agree to the CLA terms 👍 @jayshrivastava

@jayshrivastava
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation Dialog (y/n) after hitting D
3 participants