feat!: Streaming + Event Streams #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epau
force-pushed
the
870-event-streaming-impl
branch
from
3be9583 to
1033de0
Compare
The SDK doesn't stream request and responses rather it buffers them in memory. This is a problem for large requests and responses. Introduced `HttpContent` which conforms to `IStreamable` (a CRT protocol) required for streaming requests. `HttpContent` can be created from `HttpBody` which can be either a Data or a Stream. Introduced `Stream` protocol and number of implementations for different stream types. - `BufferedStream` - allows thread safe reading and writing while keeping only a fixed unread amount of data in memory. - `FileStream` - allows reading and writing from/to a file. - `CacheStream` - allows thread safe reading and writing on base stream. This is useful for streams that don't support seeking. Now we can stream requests and responses.
To support event streaming, SDK needs basic constructs like Encoder, Decoder, Signer and Message. - Add `Message` and its nested types - Add `MessageEncoder` and `MessageDecoder` protocols - Add `MessageDecoderStream` and `MessageEncoderStream` protocols which are async streams All these things are not AWS specific, hence they are in ClientRuntime instead of AWSClientRuntime. Nothing in ClientRuntime.
* wip * revert to explict header types * add docs on http2ManualDataWrites * make H2 behave same as H1 except manual writes * docs * docs and reformat * comment * reindent * not neede * bring back mocked impl * fix test cases * Update Sources/ClientRuntime/Networking/Http/CRT/HTTP2Stream+HttpBody.swift Co-authored-by: Ed Paulosky <[email protected]> * Update Sources/ClientRuntime/Networking/Streaming/BufferedStream.swift Co-authored-by: Ed Paulosky <[email protected]> * Update Sources/ClientRuntime/Networking/Http/CRT/HTTP2Stream+HttpBody.swift Co-authored-by: Ed Paulosky <[email protected]> * Update Sources/ClientRuntime/Networking/Http/CRT/CRTClientEngine.swift Co-authored-by: Ed Paulosky <[email protected]> * rename method * docs * remove whilecard import * update branch * Update Sources/ClientRuntime/Networking/Http/CRT/HTTP2Stream+HttpBody.swift Co-authored-by: Ed Paulosky <[email protected]> * fix test case * fixed compile error * extract ALPN setting * empty line * try to set Event == Element explicitly for Linux * types * fix context mutation * apply ALPN for all --------- Co-authored-by: Ganesh Jangir <[email protected]> Co-authored-by: Ed Paulosky <[email protected]>
* WIP * Uses http2 stream manager for bidirectional event streams * removes print statements * Fixes up streams * Auto formats file * fixes whitespace * More whitespace fixes * Reverts apln list to maintain existing behavior
epau
force-pushed
the
870-event-streaming-impl
branch
from
2b07799 to
708c1db
Compare
jbelkins
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.