Skip to content

step certificate create: Added subject as SAN if empty #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Feb 26, 2019

Please enter the password to encrypt the private key:
Your certificate signing request has been saved in hello.csr.
Your private key has been saved in hello.key.
$ step ca sign hello.csr hello.crt
✔ Key ID: jO37dtDbku-Qnabs5VR0Yw6YFFv9weA18dp3htvdEjs ([email protected])
✔ Please enter the password to decrypt the provisioner key:
✔ CA: https://ca.smallstep.com:9000/1.0/sign
Unauthorized

Google Chrome version 58, released in April 2017, removed support for the X.509 certificate Subject Common Name (CN) as a source of naming information when validating certificates. As a result, certificates that do not carry all relevant domain names in the Subject Alternative Name (SAN) extension result in validation failures.

The step ca subcommands take this into account by adding the subject name as a SAN if no additional SANs are provided when generating a certificate. However, this behavior was not backfilled in the step certificate command group.

@dopey dopey added the bug label Feb 26, 2019
@dopey dopey self-assigned this Feb 26, 2019
@dopey dopey requested a review from maraino February 26, 2019 22:26
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #87 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   68.46%   68.44%   -0.03%     
==========================================
  Files          59       59              
  Lines        8008     8011       +3     
==========================================
  Hits         5483     5483              
- Misses       2161     2164       +3     
  Partials      364      364
Impacted Files Coverage Δ
command/certificate/create.go 56.3% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f287f8...a078cb6. Read the comment docs.

@dopey dopey merged commit c886811 into master Feb 26, 2019
@dopey dopey deleted the max/sign2 branch February 26, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants