Skip to content

Add support for OAuth using GitHub #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add support for OAuth using GitHub #796

merged 2 commits into from
Nov 11, 2022

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Nov 11, 2022

Description

It adds the header Accept: application/json so OAuth services like GitHub returns the data in the appropriate form instead of using application/x-www-form-urlencoded. It also configures GitHub as a new provider as it does not have a "well-known" URL.

The new header does not cause any issues on Google or Microsoft.

Fixes #740

It adds the header "Accept: application/json" so OAuth services like
GitHub returns the data in the appropriate form instead of using
application/x-www-form-urlencoded. It also configures GitHub as a new
provider as it does not have a well-known url.

This header does not cause any issues on Google or Microsoft.

Fixes #740
@maraino maraino added this to the v0.23.0 milestone Nov 11, 2022
@maraino maraino requested a review from dopey November 11, 2022 03:00
@maraino maraino enabled auto-merge November 11, 2022 03:00
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Nov 11, 2022
@maraino maraino merged commit 8ec2172 into master Nov 11, 2022
@maraino maraino deleted the github-oauth branch November 11, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: using github oauth with step oauth --console-flow=device does not work
2 participants