Skip to content

Fix homebrew tests that fails trying to allocate a terminal. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Feb 12, 2019

Description

Homebrew tests on travis fails trying to allocate a terminal. This fix returns the default value if set before allocating a terminal.

Fixes #75

The fix returns a default value if set before allocating a terminal.

Fixes #75
@maraino maraino requested a review from dopey February 12, 2019 23:47
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files          59       59           
  Lines        7957     7957           
=======================================
  Hits         5436     5436           
  Misses       2156     2156           
  Partials      365      365

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b2663...6c23205. Read the comment docs.

@maraino maraino merged commit 8b0b46f into master Feb 12, 2019
@maraino maraino deleted the fix-brew-tests branch February 12, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't open a prompt terminal if the option for the prompt is already set via the cli.
2 participants