Skip to content

Support for step certificate install. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 7, 2019
Merged

Support for step certificate install. #72

merged 9 commits into from
Feb 7, 2019

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Feb 5, 2019

Description

This PR adds the new command step certificate install to allow installing a certificate (mainly root certificates) to the system truststore. This command also supports Java key store and Firefox NSS security databases using the --java and --firefox flags.

The PR also adds the --install flag to step ca bootstrap to download and install the root certificate in the system truststore.

Fixes #59

@maraino
Copy link
Collaborator Author

maraino commented Feb 5, 2019

Note: the build fails because it requires some changes available in #71

@maraino maraino requested a review from dopey February 5, 2019 23:59
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.03%.
The diff coverage is 70.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   68.28%   68.31%   +0.03%     
==========================================
  Files          58       59       +1     
  Lines        7778     7957     +179     
==========================================
+ Hits         5311     5436     +125     
- Misses       2102     2156      +54     
  Partials      365      365
Impacted Files Coverage Δ
command/certificate/certificate.go 100% <100%> (ø) ⬆️
command/certificate/install.go 68.23% <68.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509daab...d0261e2. Read the comment docs.

@maraino maraino merged commit 28e3ac9 into master Feb 7, 2019
@maraino maraino deleted the truststore branch February 7, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants