-
Notifications
You must be signed in to change notification settings - Fork 274
Support for step certificate install. #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the build fails because it requires some changes available in #71 |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 68.28% 68.31% +0.03%
==========================================
Files 58 59 +1
Lines 7778 7957 +179
==========================================
+ Hits 5311 5436 +125
- Misses 2102 2156 +54
Partials 365 365
Continue to review full report at Codecov.
|
dopey
reviewed
Feb 7, 2019
dopey
reviewed
Feb 7, 2019
dopey
reviewed
Feb 7, 2019
dopey
reviewed
Feb 7, 2019
dopey
reviewed
Feb 7, 2019
dopey
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new command
step certificate install
to allow installing a certificate (mainly root certificates) to the system truststore. This command also supports Java key store and Firefox NSS security databases using the--java
and--firefox
flags.The PR also adds the
--install
flag tostep ca bootstrap
to download and install the root certificate in the system truststore.Fixes #59