Log invalid http requests into oauth server #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log HTTP requests to OAuth HTTP server smallstep#29
maraino
reviewed
Oct 1, 2018
| if req.RequestURI == "/robots.txt" { | ||
| fmt.Printf("** You may have an app or browser plugin that needs to be turned off **\n\n") | ||
| } | ||
| } |
There was a problem hiding this comment.
Just logging the issue won't avoid the server shutdown. Here we should return a 403 or 404 in those cases, but without using the badRequest method, as it will send a signal to stop the server.
We should also use os.Stderr to log those errors.
|
I'm merging this as a first pass to resolve the issue. It's more informative than what we currently have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log HTTP requests to OAuth HTTP server #29
Description
This PR will provide more logging around invalid http requests into the oauth server.
Currently, if any 3rd party apps or plugins, such as wappalyzer, make the first request into oauth server the redirect cannot be handled and there are no logs indicating what is happening or how to fix.
In the case of wappalyzer it's sending a request to /robots.txt, which can be used to give users a useful debugging suggestion.