Skip to content

Feat x509 validity #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alvidofaisal
Copy link

Name of feature:

Enable --cert-not-before and --cert-not-after for X.509 certificate tokens

Pain or issue this feature alleviates:

Currently, the step ca token command only supports the --cert-not-before and --cert-not-after flags for SSH certificates. This PR extends this functionality to X.509 certificates, allowing you to enforce specific validity periods for X.509 certificate tokens directly at the time of token creation. This is useful for scenarios where one-time tokens are issued to third parties to enroll for a certificate, and a shorter certificate runtime than the provisioner's maximum is desired.

Why is this important to the project (if not answered above):

This enhancement provides more granular control over certificate validity for X.509 tokens, improving security and flexibility in certificate issuance workflows.

Is there documentation on how to use this feature? If so, where?

The command-line help for step ca token will reflect this change. The public documentation on smallstep.com (specifically https://smallstep.com/docs/step-cli/reference/ca/token/#options) will need to be updated to remove the SSH-only restriction for these flags. (This has been noted as a separate task).

In what environments or workflows is this feature supported?

This feature is supported wherever step ca token is used to generate tokens for X.509 certificates, in both online and offline CA modes.

In what environments or workflows is this feature explicitly NOT supported (if any)?

There are no environments or workflows where this feature is explicitly not supported, beyond the general requirements for using the step ca token command.

Supporting links/other PRs/issues:

💔Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters --cert-not-after and --cert-not-before of step ca token for non-ssh certificates
1 participant