fix: removes unused polyfills from replace section #2858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
shopware5 has chosen to add polyfill replacements for libraries that are not used or not relevant to be replaced. While there is nothing wrong with it skipping polyfills, if there a package requiring it, there will be a conflict.
Considering #2853 there might be use cases where someone would like to add shopware5 as a dev requirement, but will fail if there is conflicts due to the polyfill. Although time has told that this is very unlikely (or was never reported) the docs of symfony/polyfill https://github.com/symfony/polyfill?tab=readme-ov-file#design recommend only to replace them if provided by the package or if they can safely be skipped e.g. of an unsupported php version.
2. What does this change do, exactly?
Instead of not installing polyfills, it will not install those into the vendor directory. For PHP 7.4 it will increase the vendor directory by ~33% (42 MB) as for PHP 8.2 only by ~0,12% (2 MB).
3. Describe each step to reproduce the issue or behaviour.
Please refer to composer/composer#12412 .
4. Please link to the relevant issues (if any).
#2853
5. Which documentation changes (if any) need to be made because of this PR?
None required
6. Checklist