AMD-AMF 対応 #137
Merged
AMD-AMF 対応 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k into feature/amd-amf
There was a problem hiding this comment.
PR Overview
This PR adds support for AMD AMF by introducing a new e2e test workflow, updating existing workflows, enhancing the Sora SDK to support AMD AMF, and refining logging configuration in tests.
- Added a dedicated e2e test workflow for AMD AMF.
- Introduced new tests for AMD AMF support and updated existing workflow triggers and versioning.
- Updated the changelog to document AMD AMF support and logging enhancements.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/e2e-test-amd-amf.yml | Added AMD AMF-specific e2e test workflow with environment variables and job configuration. |
| tests/test_amd_amf.py | Added tests to validate AMD AMF availability and codec behavior. |
| tests/client.py | Integrated logging configuration based on the TEST_LIBWEBRTC_LOG environment variable. |
| .github/workflows/e2e-test.yml | Adjusted workflow triggers for minimal E2E tests. |
| CHANGES.md | Updated changelog to include AMD AMF support and logging updates. |
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/test_amd_amf.py:26
- The variable name 'intel_vpl_available' is misleading in the context of AMD AMF tests; it should be renamed to 'amd_amf_available'.
intel_vpl_available = False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to add support for AMD AMF, update workflow configurations, and enhance logging capabilities. The most important changes include adding new environment variables, updating workflows to include new tests, and modifying source and test files to support AMD AMF.
Support for AMD AMF:
src/sora_factory.cpp: Added checks and creation forAMFContextto support AMD AMF.src/sora_sdk_ext.cpp: AddedAMD_AMFtoVideoCodecImplementationand included new attributes forAMFContext. [1] [2] [3]Workflow updates:
.github/workflows/e2e-test-amd-amf.yml: Created a new workflow for AMD AMF end-to-end tests, including environment setup and test execution steps..github/workflows/e2e-test.yml: Modified existing workflow to exclude AMD AMF-specific files from certain triggers and updated conditions for running tests. [1] [2] [3]Logging enhancements:
.env.template: Added a new environment variableTEST_LIBWEBRTC_LOGto control WebRTC logging levels.tests/client.py: IntegratedTEST_LIBWEBRTC_LOGto set WebRTC logging severity based on environment variables.Documentation and version updates:
CHANGES.md: Documented the addition of AMD AMF support and related tests, as well as the newTEST_LIBWEBRTC_LOGenvironment variable. [1] [2] [3]VERSION: Updated the version ofSORA_CPP_SDKto2025.2.0-canary.14.New tests:
tests/test_amd_amf.py: Added new test cases for AMD AMF, including availability checks and various video codec tests.