fix(DASH): Prevent memory leak in uncompiled mode #8884
Merged
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
added
type: bug
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jul 17, 2025
matvp91
approved these changes
Jul 17, 2025
|
I think the compiler often does the same or similar optimizations to this PR (lifting things out of "this" into local variables). But it does that mainly to make the binary smaller, rather than because of memory, so it's definitely good to solve this directly. |
joeyparrish
reviewed
Jul 17, 2025
tykus160
added a commit
that referenced
this pull request
Jul 18, 2025
Follow up to #8884 based on comment #8884 (comment)
avelad
pushed a commit
that referenced
this pull request
Jul 21, 2025
Keeping `this` references in DASH uri callbacks leads to keeping DashParser instances in memory after unloading. Luckily this is only the issue in uncompiled mode, Closure Compiler handles it somehow. It is though better to fix it in case we change tooling some day.
avelad
pushed a commit
that referenced
this pull request
Jul 21, 2025
Follow up to #8884 based on comment #8884 (comment)
avelad
pushed a commit
that referenced
this pull request
Jul 21, 2025
Keeping `this` references in DASH uri callbacks leads to keeping DashParser instances in memory after unloading. Luckily this is only the issue in uncompiled mode, Closure Compiler handles it somehow. It is though better to fix it in case we change tooling some day.
avelad
pushed a commit
that referenced
this pull request
Jul 21, 2025
Follow up to #8884 based on comment #8884 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping
thisreferences in DASH uri callbacks leads to keeping DashParser instances in memory after unloading.Luckily this is only the issue in uncompiled mode, Closure Compiler handles it somehow. It is though better to fix it in case we change tooling some day.