Skip to content

fix(UI): Don't exit Fullscreen and PiP when unloading an ad #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 16, 2025

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jul 16, 2025
@avelad avelad added this to the v4.16 milestone Jul 16, 2025
@avelad avelad requested a review from a team July 16, 2025 16:53
@TAhub TAhub changed the title fix(UI): Avoid exit from Fullscreen and PiP when unloading when there is an Ad fix(UI): Don't exit Fullscreen and PiP when unloading an ad Jul 16, 2025
@avelad avelad merged commit 140abf9 into shaka-project:main Jul 16, 2025
41 of 52 checks passed
@avelad avelad deleted the ui-ad-unload branch July 17, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants