fix(Transmuxer): Fix width calculation when using HEVC-TS #8868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 0.00% |
tykus160
requested changes
Jul 11, 2025
tykus160
approved these changes
Jul 11, 2025
|
I'd like you to add something to the PR description about why this is right and the other thing was wrong. The question we always have to answer going back through history is not "what" but "why". Why is defaultDisplayWindowFlag to be ignored, but conformanceWindowFlag is what we care about? |
joeyparrish
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_display_window_flagis not somehow used to compute video dimensions from SPS.Only offsets of display window.