fix: Live to VOD discards the wrong segments when crossBoundaryStrategy is not KEEP #8863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matvp91
changed the title
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jul 10, 2025
avelad
pushed a commit
that referenced
this pull request
Jul 15, 2025
…gy is not KEEP (#8863) Due to not setting the `boundaryEnd` for the last period, we ensure we do not discard the wrong segments in a live to VOD situation (where a boundaryEnd becomes available mid stream). The same applies in live, when a period ends and a new period starts. The previous one will now have a boundaryEnd, the new one does not. Co-authored-by: @avelad
avelad
pushed a commit
that referenced
this pull request
Jul 15, 2025
…gy is not KEEP (#8863) Due to not setting the `boundaryEnd` for the last period, we ensure we do not discard the wrong segments in a live to VOD situation (where a boundaryEnd becomes available mid stream). The same applies in live, when a period ends and a new period starts. The previous one will now have a boundaryEnd, the new one does not. Co-authored-by: @avelad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to not setting the
boundaryEndfor the last period, we ensure we do not discard the wrong segments in a live to VOD situation (where a boundaryEnd becomes available mid stream).The same applies in live, when a period ends and a new period starts. The previous one will now have a boundaryEnd, the new one does not.
Co-authored-by: @avelad