Skip to content

fix(DASH): Change start number for SubNumber templating, based on DASH 6th edition #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

emilsas
Copy link
Contributor

@emilsas emilsas commented Jul 9, 2025

Close #8859

Copy link

google-cla bot commented Jul 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@emilsas emilsas changed the title Change start number for SubNumber templating, based on DASH 6th edition fix: Change start number for SubNumber templating, based on DASH 6th edition Jul 9, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad self-requested a review July 9, 2025 20:02
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Jul 9, 2025
@avelad avelad added this to the v4.16 milestone Jul 9, 2025
@avelad avelad changed the title fix: Change start number for SubNumber templating, based on DASH 6th edition fix(DASH): Change start number for SubNumber templating, based on DASH 6th edition Jul 9, 2025
@avelad avelad merged commit 7526f2b into shaka-project:main Jul 10, 2025
65 of 69 checks passed
avelad pushed a commit that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the start number for $SubNumber$ template to match new DASH spec
3 participants