Skip to content

feat(Transmuxer): Split init segment and segment data when appending to MSE #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2025
Merged

feat(Transmuxer): Split init segment and segment data when appending to MSE #8855

merged 6 commits into from
Jul 9, 2025
+102 −81

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 9, 2025 •
edited
Loading

Also fixes the TS-HEVC transmuxer, SPS parsing was wrong.

@avelad avelad requested a review from tykus160 July 9, 2025 10:46
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: transmuxer The issue involves our built-in transmuxer labels Jul 9, 2025
@avelad avelad added this to the v4.16 milestone Jul 9, 2025
@avelad
Copy link
Member Author

avelad commented Jul 9, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8855

tykus160
tykus160 requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend description and add integration test if possible.
Also it should be marked as an improvement as it involves API change.

@avelad avelad changed the title fix(Transmuxer): Split init segment and segment data when appending to MSE feat(Transmuxer): Split init segment and segment data when appending to MSE Jul 9, 2025
@avelad avelad added type: enhancement New feature or request and removed type: bug Something isn't working correctly labels Jul 9, 2025
@avelad
Copy link
Member Author

avelad commented Jul 9, 2025

@shaka-bot test

@avelad avelad requested a review from tykus160 July 9, 2025 11:28
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8855

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 32.88%

tykus160
tykus160 reviewed Jul 9, 2025
View reviewed changes
@avelad avelad merged commit b59066e into shaka-project:main Jul 9, 2025
45 of 47 checks passed
@avelad avelad deleted the transmuxer branch July 9, 2025 12:57
@shaka-bot shaka-bot mentioned this pull request Jul 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tykus160 tykus160 tykus160 approved these changes

Assignees
No one assigned
Labels
component: transmuxer The issue involves our built-in transmuxer priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Projects
None yet
Milestone
v4.16
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @tykus160