refactor: fix upcoming Closure Compiler type errors on Symbol.iterator #8851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on making ClosureCompiler understand well-known symbol properties, such as Symbol.iterator. google/closure-compiler#1737 (My immediate interest is fixing internal Google usage of shaka player, but the open source compiler will eventually get the same update.)
lauraharker
changed the title
|
Incremental code coverage: 100.00% |
…lable iterator type
joeyparrish
approved these changes
Jul 10, 2025
|
Thank you so much! |
avelad
pushed a commit
that referenced
this pull request
Jul 15, 2025
#8851) Closure Compiler will soon start typechecking well-known symbol properties, such as Symbol.iterator - see google/closure-compiler#1737. This will cause some type errors in existing code that implements `Iterable` (for context, I ran into these errors in google's internal repo) that is missing a Symbol.iterator override or `@override` annotation
avelad
pushed a commit
that referenced
this pull request
Jul 15, 2025
#8851) Closure Compiler will soon start typechecking well-known symbol properties, such as Symbol.iterator - see google/closure-compiler#1737. This will cause some type errors in existing code that implements `Iterable` (for context, I ran into these errors in google's internal repo) that is missing a Symbol.iterator override or `@override` annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure Compiler will soon start typechecking well-known symbol properties, such as Symbol.iterator - see
google/closure-compiler#1737.
This will cause some type errors in existing code that implements
Iterable(for context, I ran into these errors in google's internal repo) that is missing a Symbol.iterator override or@overrideannotation