Skip to content

fix(DASH): Consider codec profile when matching multi-period renditions #8842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Jul 7, 2025

Fixes #8839

Changes how do we consider best AV match. Exact codec equality is now better than codec compatibility.

@tykus160 tykus160 added this to the v4.16 milestone Jul 7, 2025
@tykus160 tykus160 requested review from joeyparrish, avelad and TAhub July 7, 2025 09:55
@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Jul 7, 2025
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jul 7, 2025

Incremental code coverage: 95.08%

@avelad avelad merged commit f69a7fa into shaka-project:main Jul 7, 2025
31 of 32 checks passed
avelad pushed a commit that referenced this pull request Jul 7, 2025
…ns (#8842)

Fixes #8839

Changes how do we consider best AV match. Exact codec equality is now
better than codec compatibility.
avelad pushed a commit that referenced this pull request Jul 7, 2025
…ns (#8842)

Fixes #8839

Changes how do we consider best AV match. Exact codec equality is now
better than codec compatibility.
@tykus160 tykus160 deleted the wt-pc-another-fix branch July 7, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback stops when transitioning between periods - no video segments being fetched.
3 participants