Skip to content

fix: Fix disable captions after load using src= on Safari #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 4, 2025

Fixes #8840

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround browser: Safari Issues affecting Safari or WebKit derivatives labels Jul 4, 2025
@avelad avelad added this to the v4.16 milestone Jul 4, 2025
@avelad avelad requested review from joeyparrish, TAhub and tykus160 July 4, 2025 10:36
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jul 4, 2025

Incremental code coverage: 100.00%

Co-authored-by: Theodore Abshire <[email protected]>
@avelad avelad requested a review from TAhub July 6, 2025 09:55
@avelad avelad merged commit 34484a3 into shaka-project:main Jul 7, 2025
18 checks passed
@avelad avelad deleted the src=-subs branch July 7, 2025 08:07
avelad added a commit that referenced this pull request Jul 7, 2025
avelad added a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about disabling captions in safari using native HLS
3 participants