fix(LCEVC): Create segmentIndex on makeAbortDecision_ #8838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NetworkInformation.downlink` API is unavailable on Firefox. Without this API, the player starts playback in a lower quality and performs an ABR switch once sufficient network data is available. This PR ensures the switch / abort logic creates the `segmentIndex` for `dependencyStream` correctly in this edge case
avelad
added
type: bug
avelad
approved these changes
Jul 3, 2025
|
Incremental code coverage: 35.71% |
avelad
pushed a commit
that referenced
this pull request
Jul 7, 2025
The `NetworkInformation.downlink` API is unavailable on Firefox. Without this API, the player starts playback in a lower quality and performs an ABR switch once sufficient network data is available. This PR ensures the switch / abort logic creates the `segmentIndex` for `dependencyStream` correctly in this edge case.
avelad
pushed a commit
that referenced
this pull request
Jul 7, 2025
The `NetworkInformation.downlink` API is unavailable on Firefox. Without this API, the player starts playback in a lower quality and performs an ABR switch once sufficient network data is available. This PR ensures the switch / abort logic creates the `segmentIndex` for `dependencyStream` correctly in this edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NetworkInformation.downlinkAPI is unavailable on Firefox. Without this API, the player starts playback in a lower quality and performs an ABR switch once sufficient network data is available. This PR ensures the switch / abort logic creates thesegmentIndexfordependencyStreamcorrectly in this edge case.