Skip to content

fix(ABR): Fix abr switching in some cases #8836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 3, 2025

Try to suggest new stream although cacheLoadThreshold is not met for a given segment. Change the cache Load Threshold value to a more appropriate value since we now have removeLatencyFromFirstPacketTime active by default.

Try to suggest new stream althorung cacheLoadThreshold is not met for a given segment.
Change the cache Load Threshold value to a more appropriate value since we now have removeLatencyFromFirstPacketTime active by default.
@avelad avelad changed the title fix(ABR): Fix abr switching in some case fix(ABR): Fix abr switching in some cases Jul 3, 2025
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 3, 2025
@avelad avelad added this to the v4.16 milestone Jul 3, 2025
@avelad avelad requested a review from tykus160 July 3, 2025 11:26
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit fbb7161 into shaka-project:main Jul 3, 2025
49 of 52 checks passed
@avelad avelad deleted the abr-switching branch July 3, 2025 12:51
avelad added a commit that referenced this pull request Jul 7, 2025
Try to suggest new stream although cacheLoadThreshold is not met for a
given segment. Change the cache Load Threshold value to a more
appropriate value since we now have removeLatencyFromFirstPacketTime
active by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants