fix(HLS): Fix preload initial variant #8835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to obtain the necessary DRM information, which in most cases is not available until the media playlist is downloaded. Also avoid DRM setup for VOD that does not need it for HLS Fixes shaka-project#8830
avelad
added
type: bug
|
Incremental code coverage: 97.59% |
TAhub
approved these changes
Jul 7, 2025
tykus160
reviewed
Jul 7, 2025
tykus160
approved these changes
Jul 7, 2025
avelad
added a commit
that referenced
this pull request
Jul 7, 2025
This is necessary to obtain the necessary DRM information, which in most cases is not available until the media playlist is downloaded. Also avoid DRM setup for VOD that does not need it for HLS. Fixes #8830
avelad
added a commit
to avelad/shaka-player
that referenced
this pull request
Jul 15, 2025
Regression introduced in shaka-project#8835 by changing the order of operations in the preload manager.
avelad
added a commit
that referenced
this pull request
Jul 15, 2025
Regression introduced in #8835 by changing the order of operations in the preload manager.
avelad
added a commit
that referenced
this pull request
Jul 21, 2025
Regression introduced in #8835 by changing the order of operations in the preload manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to obtain the necessary DRM information, which in most cases is not available until the media playlist is downloaded.
Also avoid DRM setup for VOD that does not need it for HLS.
Fixes #8830