Skip to content

chore: Remove redundant EMSG event #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Jul 3, 2025

This event is a leftover and it's not needed since we are using RegionTimeline now for managing EMSG events. Additionally, it wasn't even fired, just being created and questioning its own existence.

@tykus160 tykus160 requested a review from avelad July 3, 2025 08:46
@tykus160 tykus160 added the type: code health A code health issue label Jul 3, 2025
@tykus160 tykus160 added this to the v4.16 milestone Jul 3, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 82138ab into shaka-project:main Jul 3, 2025
31 of 35 checks passed
avelad pushed a commit that referenced this pull request Jul 7, 2025
This event is a leftover and it's not needed since we are using
RegionTimeline now for managing EMSG events. Additionally, it wasn't
even fired, just being created and questioning its own existence.
avelad pushed a commit that referenced this pull request Jul 7, 2025
This event is a leftover and it's not needed since we are using
RegionTimeline now for managing EMSG events. Additionally, it wasn't
even fired, just being created and questioning its own existence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants