fix: Bail out on other decodingInfos when we found a preferred and supported one. #8829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matvp91
changed the title
avelad
added
type: bug
tykus160
approved these changes
Jul 2, 2025
avelad
approved these changes
Jul 2, 2025
|
Incremental code coverage: 100.00% |
avelad
pushed a commit
that referenced
this pull request
Jul 7, 2025
…pported one. (#8829) Pick a multi DRM asset, set `preferredKeySystems` to prefer PlayReady over Widevine and run on a device that does not support PlayReady (eg; Chrome). A `REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE` is thrown. This is due to the logic in `getDecodingInfosForVariants` where we bail out on probing other decodingInfos when we found a prefered one, but we didn't check whether it was supported or not. As a result, Widevine was never checked and PlayReady was left marked as unsupported.
avelad
pushed a commit
that referenced
this pull request
Jul 7, 2025
…pported one. (#8829) Pick a multi DRM asset, set `preferredKeySystems` to prefer PlayReady over Widevine and run on a device that does not support PlayReady (eg; Chrome). A `REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE` is thrown. This is due to the logic in `getDecodingInfosForVariants` where we bail out on probing other decodingInfos when we found a prefered one, but we didn't check whether it was supported or not. As a result, Widevine was never checked and PlayReady was left marked as unsupported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick a multi DRM asset, set
preferredKeySystemsto prefer PlayReady over Widevine and run on a device that does not support PlayReady (eg; Chrome).A
REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLEis thrown.This is due to the logic in
getDecodingInfosForVariantswhere we bail out on probing other decodingInfos when we found a prefered one, but we didn't check whether it was supported or not. As a result, Widevine was never checked and PlayReady was left marked as unsupported.