Skip to content

chore: Simplify DrmEngine queryMediaKeys() #8828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Jul 1, 2025

queryMediaKeys() was able to work both with variants and key system configs. The latter option was needed only for initForRemoval() method. By removing it we are able to make the logic more easy to follow.
Additionally, compiled build is now 2 KB smaller.

@tykus160 tykus160 added this to the v4.16 milestone Jul 1, 2025
@tykus160 tykus160 requested review from joeyparrish, avelad and TAhub July 1, 2025 14:28
@tykus160 tykus160 added type: code health A code health issue priority: P4 Nice to have / wishful thinking labels Jul 1, 2025
@avelad
Copy link
Member

avelad commented Jul 1, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8828

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 98.90%

@tykus160 tykus160 merged commit fd7ee12 into shaka-project:main Jul 2, 2025
46 of 48 checks passed
@tykus160 tykus160 deleted the wt-drm-query-media-keys branch July 2, 2025 09:21
avelad pushed a commit that referenced this pull request Jul 7, 2025
`queryMediaKeys()` was able to work both with variants and key system
configs. The latter option was needed only for `initForRemoval()`
method. By removing it we are able to make the logic more easy to
follow.
Additionally, compiled build is now 2 KB smaller.
avelad pushed a commit that referenced this pull request Jul 7, 2025
`queryMediaKeys()` was able to work both with variants and key system
configs. The latter option was needed only for `initForRemoval()`
method. By removing it we are able to make the logic more easy to
follow.
Additionally, compiled build is now 2 KB smaller.
avelad pushed a commit that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P4 Nice to have / wishful thinking type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants