Skip to content

fix(Demo): Assign valid regex to asset name input #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

tykus160
Copy link
Member

Setting partial regex causes following error logged in console on Firefox:

Unable to check <input pattern=‘^(?!( *’> because ‘/^(?!( */v’ is not a valid regexp: unterminated parenthetical

@tykus160 tykus160 added this to the v4.16 milestone Jun 27, 2025
@tykus160 tykus160 requested a review from avelad June 27, 2025 12:43
@tykus160 tykus160 added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent labels Jun 27, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 3dd685c into shaka-project:main Jun 27, 2025
47 of 51 checks passed
joeyparrish pushed a commit that referenced this pull request Jun 27, 2025
Setting partial regex causes following error logged in console on
Firefox:
```
Unable to check <input pattern=‘^(?!( *’> because ‘/^(?!( */v’ is not a valid regexp: unterminated parenthetical
```
joeyparrish pushed a commit that referenced this pull request Jun 27, 2025
Setting partial regex causes following error logged in console on
Firefox:
```
Unable to check <input pattern=‘^(?!( *’> because ‘/^(?!( */v’ is not a valid regexp: unterminated parenthetical
```
@tykus160 tykus160 deleted the wt-input-regex branch June 27, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants