fix: Fix end-of-stream detection for VOD #8813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR shaka-project#8603 refactored the conditions for being "buffered to the end". Two of these conditions from Player didn't fit in the new location (Playhead). One (this.isEnded()) was moved, and the other (this.mediaSourceEngine_.ended()) was dropped by accident. This restores the dropped condition next to isEnded(). Verified on Chromecast.
|
Incremental code coverage: 100.00% |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
avelad
added
type: bug
avelad
approved these changes
Jun 27, 2025
tykus160
approved these changes
Jun 27, 2025
joeyparrish
added a commit
that referenced
this pull request
Jun 27, 2025
PR #8603 refactored the conditions for being "buffered to the end". Two of these conditions from Player didn't fit in the new location (Playhead). One (this.isEnded()) was moved, and the other (this.mediaSourceEngine_.ended()) was dropped by accident. This restores the dropped condition next to isEnded(). Verified in the Cast Application Framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8603 refactored the conditions for being "buffered to the end". Two of these conditions from Player didn't fit in the new location (Playhead). One (this.isEnded()) was moved, and the other (this.mediaSourceEngine_.ended()) was dropped by accident. This restores the dropped condition next to isEnded().
Verified in the Cast Application Framework.