fix(HLS): Fix resync issues on Safari #8808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
added
type: bug
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jun 26, 2025
joeyparrish
pushed a commit
that referenced
this pull request
Jun 26, 2025
Removes duplicated logic around timestamp offset checks - now check is only in `resync()` method. It should stay there, because it ensures it will be executed only in sequence mode and also avoids otherwise unnecessary `abort()` call. Increases threshold to 150 ms as it was the originally proposed value and gives better experience. Now timestamp offset change won't be applied in sequence mode if it's less than 150ms from buffer end, regardless of manifest type.
joeyparrish
pushed a commit
that referenced
this pull request
Jun 27, 2025
Removes duplicated logic around timestamp offset checks - now check is only in `resync()` method. It should stay there, because it ensures it will be executed only in sequence mode and also avoids otherwise unnecessary `abort()` call. Increases threshold to 150 ms as it was the originally proposed value and gives better experience. Now timestamp offset change won't be applied in sequence mode if it's less than 150ms from buffer end, regardless of manifest type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicated logic around timestamp offset checks - now check is only in
resync()method. It should stay there, because it ensures it will be executed only in sequence mode and also avoids otherwise unnecessaryabort()call.Increases threshold to 150 ms as it was the originally proposed value and gives better experience.
Now timestamp offset change won't be applied in sequence mode if it's less than 150ms from buffer end, regardless of manifest type.