fix: Fix Apple Vision Pro (Vision OS) detection and other VR devices detection #8805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
tykus160
reviewed
Jun 26, 2025
| @@ -234,6 +234,7 @@ shaka.device.IDevice.DeviceType = { | |||
| 'MOBILE': 'MOBILE', | |||
| 'TV': 'TV', | |||
| 'VR': 'VR', | |||
| 'APPLE_VR': 'APPLE_VR', | |||
There was a problem hiding this comment.
maybe instead of adding new device type which is essentially the same as before, but with brand added, we should expose manufacturer brand in API?
There was a problem hiding this comment.
That's what I thought at first, but I don't think it's something we can easily obtain, and since we only have this one case, I've left it at that for now.
There was a problem hiding this comment.
It's not exposed API yet, so we can use it like that and see how it serves our needs.
|
Incremental code coverage: 75.00% |
tykus160
approved these changes
Jun 26, 2025
joeyparrish
pushed a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.