-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(CMCD): Add CMCD version 2 response mode #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
juanmanuel-qualabs
wants to merge
42
commits into
shaka-project:main
from
qualabs:cmcdv2/response-mode-enabled-keys
Closed
feat(CMCD): Add CMCD version 2 response mode #8781
juanmanuel-qualabs
wants to merge
42
commits into
shaka-project:main
from
qualabs:cmcdv2/response-mode-enabled-keys
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcdv2/response mode
Added constants for CMCD Mode
…culated once and sent multiple times
Co-authored-by: Álvaro Velad Galván <[email protected]>
Co-authored-by: Álvaro Velad Galván <[email protected]>
…reateCmcdManager for CMCD V1 Tests
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on the implementation of Response Mode functionalities for version 2 of the Common Media Client Data (CMCD v2) specification within the Shaka Player project.
Key changes made in this pull request include:
shaka.extern.CmcdTarget
, was introduced. This configuration allows specifying the transmission strategy (mode=response) since targets can also be configured for event mode (mode=event), whether it's enabled (enabled), if it uses HTTP headers mode (useHeaders=true
) or query parameters mode, the destination URL (url), and specific keys to include (includeKeys
). For Response Mode, the mode value includes 'response'.includeKeys
) and filter specific keys for both Request Mode and each Response Mode target was also enabled. Also, CMCD dictionary definitions were moved to a new dedicated section to improve structureThe following keys are defined in the CMCD v2 specification but are not calculated or attached to requests/responses in the
cmcd_manager.js
code:ab
(Aggregate encoded bitrate)tbl
(Target Buffer length)cdn
(CDN Id)bg
(Backgrounded)sta
(State)ts
(Timestamp)tpb
(Top playable bitrate)lb
(Lowest encoded bitrate)tab
(Top aggregated encoded bitrate)lab
(Lowest aggregated encoded bitrate)pt
(Playhead time)ec
(Player Error Code)rc
(Response code)ttfb
(Time to first byte)ttfbb
(Time to first body byte)ttlb
(Time to last byte)url
(Request URL)cmsdd
(CMSD Dynamic Header)cmsds
(CMSD Static Header)