Skip to content

fix(Demo): Fix keep custom config on page reload #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 20, 2025

The previous fix doesn't work with streaming.lowLatencyMode config.

@avelad avelad requested review from joeyparrish, TAhub and tykus160 June 20, 2025 09:04
@avelad avelad added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround labels Jun 20, 2025
@avelad avelad added this to the v4.16 milestone Jun 20, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 35124e4 into shaka-project:main Jun 21, 2025
24 checks passed
@avelad avelad deleted the demo-config branch June 23, 2025 06:45
avelad added a commit that referenced this pull request Jun 23, 2025
The previous fix doesn't work with streaming.lowLatencyMode config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants