Skip to content

docs(UI): Add supported shortcuts #8768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2025
Merged

docs(UI): Add supported shortcuts #8768

merged 9 commits into from
Jun 19, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 18, 2025

No description provided.

@avelad avelad added type: docs Improvements or fixes to documentation component: UI The issue involves the Shaka Player UI labels Jun 18, 2025
@avelad avelad requested a review from tykus160 June 18, 2025 14:28
@avelad avelad added this to the v4.16 milestone Jun 18, 2025
tykus160
tykus160 requested changes Jun 18, 2025
View reviewed changes
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot be customized, so I think it belongs more to UI Library: basic usage.

@avelad avelad requested a review from tykus160 June 18, 2025 14:44
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

tykus160
tykus160 previously requested changes Jun 18, 2025
View reviewed changes
@avelad avelad requested review from tykus160, joeyparrish and TAhub June 18, 2025 15:41
TAhub
TAhub requested changes Jun 19, 2025
View reviewed changes
avelad and others added 3 commits June 19, 2025 21:30
@avelad @TAhub
Update docs/tutorials/ui.md
36b5713 
Co-authored-by: Theodore Abshire <[email protected]>
@avelad @TAhub
Update docs/tutorials/ui.md
fd9cede 
Co-authored-by: Theodore Abshire <[email protected]>
@avelad @TAhub
Update docs/tutorials/ui.md
1e04417 
Co-authored-by: Theodore Abshire <[email protected]>
@avelad avelad requested a review from TAhub June 19, 2025 19:30
TAhub
TAhub requested changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@TAhub TAhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you had more "activating buttons" that I didn't notice. This should be fine after these.

avelad and others added 2 commits June 19, 2025 21:34
@avelad @TAhub
Update docs/tutorials/ui.md
f949ab8 
Co-authored-by: Theodore Abshire <[email protected]>
@avelad @TAhub
Update docs/tutorials/ui.md
178c60d 
Co-authored-by: Theodore Abshire <[email protected]>
@avelad avelad requested a review from TAhub June 19, 2025 19:35
@avelad avelad dismissed tykus160’s stale review June 19, 2025 19:35

Reviewed by Theodore

@avelad avelad merged commit 03686ac into shaka-project:main Jun 19, 2025
17 of 18 checks passed
@avelad avelad deleted the ui-doc branch June 19, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TAhub TAhub TAhub approved these changes

@tykus160 tykus160 Awaiting requested review from tykus160

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI type: docs Improvements or fixes to documentation
Projects
None yet
Milestone
v4.16
Development

Successfully merging this pull request may close these issues.
4 participants
@avelad @shaka-bot @TAhub @tykus160