fix(DASH): Use the correct Representation ID for Uri substitution of media segments #8760
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
type: bug
tykus160
previously requested changes
Jun 18, 2025
|
Incremental code coverage: 100.00% |
|
I can confirm the bug and that the fix works! (Tested with Safari) @gmcgarry please add unit test! Thanks! |
avelad
requested changes
Jun 20, 2025
…s-segments' into dolby/fix-supplemental-codecs-segments
avelad
approved these changes
Jun 20, 2025
avelad
pushed a commit
that referenced
this pull request
Jun 23, 2025
…media segments (#8760) For DASH segment templates, MpdUtils.fillUriTemplate() is used for substitution of tokens in the fetch URL, like $RepresentationID$. When supplemental codecs are used, the incorrect RepresentationID will be substituted for media segments. The initialisation segment is correctly substituted. The symptom is that fetches for media segments will fail with 404 response codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DASH segment templates, MpdUtils.fillUriTemplate() is used for substitution of tokens in the fetch URL, like
The symptom is that fetches for media segments will fail with 404 response codes.
Here is a sample mpd: https://chromium.dolby.link/media/supplemental-segments/manifest.mpd
The correct media path is: https://chromium.dolby.link/media/supplemental-segments/video/seg-5.m4s
The incorrect media path is: https://chromium.dolby.link/media/supplemental-segments/video_supplementalCodecs/seg-5.m4s