Skip to content

fix(UI): The playback time displayed in the seek bar is different from currentTime when click #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 18, 2025

Fixes #7129

…m currentTime when click
@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jun 18, 2025
@avelad avelad added this to the v4.16 milestone Jun 18, 2025
@avelad
Copy link
Member Author

avelad commented Jun 18, 2025

@TAhub I've added many comments, some of which may seem unnecessary, but they help understand the code and fix the problem. If you still want me to remove them, I can.

@avelad avelad requested a review from TAhub June 18, 2025 09:12
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 18, 2025

Incremental code coverage: 28.57%

avelad added 2 commits June 18, 2025 12:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
avelad added 4 commits June 19, 2025 08:08
@avelad avelad requested a review from TAhub June 19, 2025 06:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Theodore Abshire <[email protected]>
@avelad avelad merged commit c97e0a6 into shaka-project:main Jun 19, 2025
30 of 32 checks passed
@avelad avelad deleted the time-seekbar branch June 19, 2025 07:01
avelad added a commit that referenced this pull request Jun 23, 2025
…m currentTime when click (#8758)

Fixes #7129

---------

Co-authored-by: Theodore Abshire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The playback time displayed in the seek bar of the UI Library is different from currentTime
4 participants