-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(UI): The playback time displayed in the seek bar is different from currentTime when click #8758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+41
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…m currentTime when click
@TAhub I've added many comments, some of which may seem unnecessary, but they help understand the code and fix the problem. If you still want me to remove them, I can. |
Incremental code coverage: 28.57% |
Loading status checks…
Loading status checks…
tykus160
reviewed
Jun 18, 2025
Loading status checks…
TAhub
requested changes
Jun 19, 2025
Loading status checks…
Loading status checks…
Loading status checks…
Loading status checks…
TAhub
requested changes
Jun 19, 2025
Loading status checks…
Co-authored-by: Theodore Abshire <[email protected]>
TAhub
approved these changes
Jun 19, 2025
avelad
added a commit
that referenced
this pull request
Jun 23, 2025
…m currentTime when click (#8758) Fixes #7129 --------- Co-authored-by: Theodore Abshire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: UI
The issue involves the Shaka Player UI
priority: P2
Smaller impact or easy workaround
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7129