Extends DocumentAssembler to also apply HTML formatting on content in table cells
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting on content in table cells
|
Thank you @nefarius for this PR. |
|
I tested it locally and it is working, if you're open to it I may provide further PRs for docs update and refactoring duplicated code etc. How to unit test this particular case I do not yet know tho, it is a fairly big project 😅 |
|
This all sounds along the right lines to me guys. I will take a look next
week and can give guidance on adding tests :)
…On Sat, 12 Jul 2025, 15:00 Benjamin Höglinger-Stelzer, < ***@***.***> wrote:
*nefarius* left a comment (sergey-tihon/Clippit#101)
<#101 (comment)>
I tested it locally and it is working, if you're open to it I may provide
further PRs for docs update and refactoring duplicated code etc.
How to unit test this particular case I do not yet know tho, it is a
fairly big project 😅
—
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIA3JHRNKPBUEW2UWW4KR633IEBGRAVCNFSM6AAAAACBJUA7KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRVGMYTMMBVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #70 and builds upon #86 to also interpret basic HTML-formatted values in templates using table cells.