Remove the SHACL-based prefix declaration. Fixes #1001 #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with small ttl file.
sa-bpelakh
changed the title
Co-authored-by: Boris Pelakh <[email protected]>
stevenchalem
approved these changes
Jan 26, 2024
rjyounes
requested changes
Jan 29, 2024
rjyounes
requested changes
Jan 30, 2024
gistNamespaceInformation.ttl
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| <https://w3id.org/semanticarts/ontology/gistCore> | |||
There was a problem hiding this comment.
Why is this going into the gistCore ontology? It should have its own ontology declaration.
gistNamespaceInformation.ttl
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| <https://w3id.org/semanticarts/ontology/gistCore> | |||
| sh:declare gist:_PrefixDeclaration_gist ; | |||
| skos:editorialNote "Please note that including the file gistNamespaceInformation.ttl will break the OWL2 DL conformance of the gist ontology. This need for this change is described in https://github.com/semanticarts/gist/issues/1001 ." ; | |||
There was a problem hiding this comment.
Suggested change
| skos:editorialNote "Please note that including the file gistNamespaceInformation.ttl will break the OWL2 DL conformance of the gist ontology. This need for this change is described in https://github.com/semanticarts/gist/issues/1001 ." ; | |
| skos:editorialNote "Please note that importing this ontology will break OWL2 DL conformance because SHACL is not an OWL ontology." ; |
rjyounes
reviewed
Jan 30, 2024
| @@ -0,0 +1,3 @@ | |||
| ### Minor Updates | |||
|
|
|||
| - Removed SHACL terms to the file gistNamespaceInformation.ttl in order to preserve the OWL2 DL conformance of the core ontology. Issue [#1001](https://github.com/semanticarts/gist/issues/1001). | |||
There was a problem hiding this comment.
Suggested change
| - Removed SHACL terms to the file gistNamespaceInformation.ttl in order to preserve the OWL2 DL conformance of the core ontology. Issue [#1001](https://github.com/semanticarts/gist/issues/1001). | |
| - Moved SHACL references to the `gistPrefixDeclarations` file. Issue [#1001](https://github.com/semanticarts/gist/issues/1001). |
Note that we don't include rationale in the release notes. They can look it up in the issue if they want. This seems nitpicky but if we go down that route we'll end up with a lot of unnecessary stuff in the release notes.
rjyounes
reviewed
Jan 30, 2024
rjyounes
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1001.
Move declaration into standalone ttl file.