Do not splice array in normaliseNewLines#988
Open
live627 wants to merge 1 commit intosamclarke:masterfrom
Open
Do not splice array in normaliseNewLines#988live627 wants to merge 1 commit intosamclarke:masterfrom
live627 wants to merge 1 commit intosamclarke:masterfrom
Conversation
Splicing reindexes arrays, which is a behavior that we do not want in a hot loop. My performance profiling reveals that this is thee only instance of splicing arrays that shows enough time taken to actually show up.
live627
force-pushed
the
normaliseNewLines
branch
from
31c107e to
4327418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splicing reindexes arrays, which is a behavior that we do not want in a hot loop.
My performance profiling reveals that this is thee only instance of splicing arrays that shows enough time taken to actually show up.