Check if texput.log exists (fix #21) #29
Conversation
|
Thanks for the PR @quantumsheep ! I'll verify this change this weekend and have it merged. I'll then publish a new version with your fix :) |
|
Hello! Waiting for the PR to be merged 😄 |
|
So sorry for my delay :( I need to stop making promises on dates and then not meeting them... with that said I will definitely get to this tomorrow, I've added some alarms/reminders to make sure I do lol. Thanks for your patience @quantumsheep |
|
Don't worry, it's not that much of an urge and you don't owe me anything! Take your time, delays doesn't matter :) |
index.js
Outdated
| } | ||
| fs.stat(errorLogPath, (err, stats) => { | ||
| if (err || !stats.isFile()) { | ||
| outputStream.emit('error', new Error('LaTeX Syntax Error')) |
There was a problem hiding this comment.
nit: Can you change error message to be something more along the lines of the error log file not existing?
There was a problem hiding this comment.
Like using err variable?
There was a problem hiding this comment.
sorry, i meant instead of LateX Syntax Error it should be a different message like No error log file or something
There was a problem hiding this comment.
Here you go! No error log file was perfect.
|
Thanks very much for the fix @quantumsheep! I will publish a new version once I get home :) |
|
Thanks you :) |
|
|
Fix #21 by checking if
texput.logexists before opening it as a read stream.