Skip to content

VC 2010 Compile Issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

VC 2010 Compile Issues #3

wants to merge 1 commit into from

Conversation

cfis
Copy link

@cfis cfis commented Aug 16, 2011

These changes allow VC++ to compile ruby-debug-bas19x.

Changes are:

  • In extconf.rb, iseq.h requires vm_core.h to compile. Not sure why this doesn't blow up other compilers
  • The declarations for rb_vm_get_sourceline and rb_iseq_compile_with_option do not match the ones in vm_core.h. They include an extra RUBY_EXTERN and therefore are not correct (note for VC RUBY_EXTERN is defined as declspec(dllimport) when compiling against a dll.
  • The remaining changes are due to VC++ requiring variable to be defined at the start of blocks when compiling c code.

Note this fixes the compilation issues, but there is still a linker issue that is due to Ruby. See http://redmine.ruby-lang.org/issues/5193

Thanks - Charlie

@denofevil
Copy link
Member

Works ok on rvm-based 1.9.2 also, merged

@denofevil denofevil closed this Aug 16, 2011
@cfis
Copy link
Author

cfis commented Aug 17, 2011

Thanks - I'll also give it a spin on MinGW.

Charlie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants