Skip to content

rust-lang/book 레포지토리와 차이나는 부분 적용 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2020

Conversation

soilSpoon
Copy link

@soilSpoon soilSpoon commented Dec 28, 2020

현재 해당 레포지토리가 https://github.com/rust-lang/book 레포지토리와 환경 차이가 많이 나서 차이나는 부분들을 적용한 PR입니다.

작업 내용

대부분의 마크다운 제외
rust-lang@77092be 기준
#232 merge 이후 merge

@rinthel
Copy link
Owner

rinthel commented Dec 29, 2020

혹시 변경된 내용을 적용해서 문서 빌드까지 해보셨는지 궁금합니다~

@soilSpoon
Copy link
Author

혹시 변경된 내용을 적용해서 문서 빌드까지 해보셨는지 궁금합니다~

@rinthel 빌드는 잘 되었는데 더 테스트 해봐야하는 내용이 있을까요?

@rinthel
Copy link
Owner

rinthel commented Dec 29, 2020

@soilSpoon 2018년 문서 빌드가 잘되는지랑 2nd 문서 빌드가 잘 되는지만 확인하면 될듯합니다-

@soilSpoon
Copy link
Author

@rinthel 둘 다 빌드 잘 됩니다~!

@rinthel
Copy link
Owner

rinthel commented Dec 29, 2020

@soilSpoon 넵넵. 그러면 순차적으로 머지하고 실제 문서의 변경사항 적용은 제가 들여다 보겠습니다. 감사합니다!

Copy link
Owner

@rinthel rinthel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 CI 관련된 수정만 좀 부탁드릴게요~

@soilSpoon
Copy link
Author

soilSpoon commented Dec 29, 2020

@rinthel 요청사항 반영하였습니다!

@rinthel rinthel merged commit 89efa46 into rinthel:master Dec 29, 2020
@soilSpoon soilSpoon deleted the feature/apply-diff branch December 29, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants