fix(api-server): lambdaLoader: improve handler import logic... #12064
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-stafflink
force-pushed
the
api-server-lambdaLoader-import-fallbacks
branch
from
3a6a238 to
50980b7
Compare
|
Related PR (lambdaLoader: add discoverfunctionsGlob option): #12063 |
For ESModule and CommonJS compatibility. When using a bundler like Rollup, the handler function is exported as default.
richard-stafflink
force-pushed
the
api-server-lambdaLoader-import-fallbacks
branch
from
50980b7 to
24f809c
Compare
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jul 11, 2025
For ESModule and CommonJS compatibility. When using a bundler like Rollup, the handler function is exported as `default`. This change defaults to a named `handler` export, just like before. But if an export like that can't be found it'll now also look for a `default` export with a `handler` property on it. All credit for this one goes to @richard-stafflink who created the original PR over at redwoodjs/graphql#12064 --------- Co-authored-by: Richard J <[email protected]>
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jul 11, 2025
For ESModule and CommonJS compatibility. When using a bundler like Rollup, the handler function is exported as `default`. This change defaults to a named `handler` export, just like before. But if an export like that can't be found it'll now also look for a `default` export with a `handler` property on it. All credit for this one goes to @richard-stafflink who created the original PR over at redwoodjs/graphql#12064 --------- Co-authored-by: Richard J <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ESModule and CommonJS compatibility.
When using a bundler like Rollup, the handler function is exported as default.
This change defaults to a named export, but has a fallback check for a named export if there is a
defaultexport.